Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

feat: use small HTTP dependency #510

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Aug 28, 2018

Improve load time from 1300 ms to 700 ms.

Before:
screen shot 2018-08-30 at 12 48 34 pm

With teeny-request:
screen shot 2018-08-30 at 12 48 25 pm

Drive-by fix: Delete unused import.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2018
@fhinkel fhinkel force-pushed the withTeeny branch 4 times, most recently from 0909872 to 31b8467 Compare August 28, 2018 21:02
Improve load time from 1000 ms to under 800 ms.

Drive-by fix: Delete unused import.
Copy link
Contributor

@DominicKramer DominicKramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided we know that using teeny-request doesn't introduce any breaking changes. Otherwise, to be safe, we should probably mark this as a breaking change.

@fhinkel
Copy link
Contributor Author

fhinkel commented Aug 28, 2018

Probably saver to mark it as breaking change. So far we haven't released anything with teeny-request, so the real test is still missing. Edit: We're about to release nodejs-translate, see PR.

@JustinBeckwith JustinBeckwith merged commit ce903bc into googleapis:master Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants