This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
feat: support apiEndpoint override #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
DominicKramer
approved these changes
May 29, 2019
51 tasks
|
@DominicKramer I ... need help 😆 The change I made was pretty minimal, and I don't know these tests well enough to know why they're blowing up the tests. Could I ask for an assist? |
|
I'm also not sure why they are failing offhand, but I'll take a look. |
|
It turned out to be a super easy typo to make. The controller test used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to
@google-cloud/common2.0, and makes theapiEndpointproperty configurable.