Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add language to profile labels #196

Merged
merged 1 commit into from May 11, 2018

Conversation

nolanmar511
Copy link
Contributor

@nolanmar511 nolanmar511 commented May 10, 2018

Fixes #196
This change also removes some unused variables from test-profiler.ts.

@nolanmar511 nolanmar511 requested a review from aalexand May 10, 2018 17:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2018
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files           6        6           
  Lines         388      388           
  Branches       62       62           
=======================================
  Hits          349      349           
  Misses         39       39
Impacted Files Coverage Δ
ts/src/profiler.ts 95.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595fdc0...abd60f0. Read the comment docs.

@aalexand
Copy link
Contributor

@nolanmar511 the Kokoro build failed?

@nolanmar511 nolanmar511 added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2018
@nolanmar511
Copy link
Contributor Author

Kokoro build failed on Node10, because the program did not finish profiling before the the tests timed out.
I'm re-running the test, but may also need to look more into why the test timed out on node10.

@nolanmar511 nolanmar511 added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 11, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 11, 2018
@nolanmar511 nolanmar511 merged commit a7b4828 into googleapis:master May 11, 2018
@aalexand
Copy link
Contributor

@nolanmar511 I don't know what I was thinking when I approved this. The language needs to be added as a deployment label, not as a profile label. #194 (which this PR doesn't link but it should have) clearly says so. Please rollback ASAP and fix properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants