New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add language to profile labels #196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 6 6
Lines 388 388
Branches 62 62
=======================================
Hits 349 349
Misses 39 39
Continue to review full report at Codecov.
|
@nolanmar511 the Kokoro build failed? |
Kokoro build failed on Node10, because the program did not finish profiling before the the tests timed out. |
@nolanmar511 I don't know what I was thinking when I approved this. The language needs to be added as a deployment label, not as a profile label. #194 (which this PR doesn't link but it should have) clearly says so. Please rollback ASAP and fix properly. |
This reverts commit a7b4828.
Fixes #196
This change also removes some unused variables from
test-profiler.ts
.