Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run e2e and unit tests with node 11 #332

Merged
merged 1 commit into from Nov 15, 2018
Merged

chore: run e2e and unit tests with node 11 #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 8 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -53,10 +53,10 @@ workflows:
filters: *release_tags
- node8:
filters: *release_tags
- node9:
filters: *release_tags
- node10:
filters: *release_tags
- node11:
filters: *release_tags
- gocheck:
filters: *release_tags
- npmaudit:
Expand All @@ -65,7 +65,8 @@ workflows:
requires:
- node6
- node8
- node9
- node10
- node11
- gocheck
- npmaudit
filters:
Expand All @@ -84,14 +85,14 @@ jobs:
- image: node:8
user: node
<<: *unit_tests
node9:
node10:
docker:
- image: node:9
- image: node:10
user: node
<<: *unit_tests
node10:
node11:
docker:
- image: node:10
- image: node:11
user: node
<<: *unit_tests
npmaudit:
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Expand Up @@ -2,8 +2,8 @@ environment:
matrix:
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "9"
- nodejs_version: "10"
- nodejs_version: "11"

install:
- ps: Install-Product node $env:nodejs_version
Expand Down
12 changes: 6 additions & 6 deletions testing/integration_test.go
View file
Open in desktop
Expand Up @@ -228,23 +228,23 @@ func TestAgentIntegration(t *testing.T) {
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node9-%s", runID),
Name: fmt.Sprintf("profiler-test-node10-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node9-%s-gce", runID),
name: fmt.Sprintf("profiler-test-node10-%s-gce", runID),
wantProfiles: []profileSummary{{"WALL", "busyLoop"}, {"HEAP", "benchmark"}},
nodeVersion: "9",
nodeVersion: "10",
},
{
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node10-%s", runID),
Name: fmt.Sprintf("profiler-test-node11-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node10-%s-gce", runID),
name: fmt.Sprintf("profiler-test-node11-%s-gce", runID),
wantProfiles: []profileSummary{{"WALL", "busyLoop"}, {"HEAP", "benchmark"}},
nodeVersion: "10",
nodeVersion: "11",
},
}
if *runOnlyV8CanaryTest {
Expand Down