Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breaking!): support API endpoint override #509

Merged
merged 4 commits into from
Jun 28, 2019
Merged

feat(breaking!): support API endpoint override #509

merged 4 commits into from
Jun 28, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2019
@nolanmar511 nolanmar511 changed the title feat: support API endpoint override feat (breaking!): support API endpoint override Jun 17, 2019
@nolanmar511
Copy link
Contributor

There are two things I'll need to be careful about with respect to this change:

  1. Updating @google-cloud/common has broken our backoff when multiple agents with the same deployment are running. We don't have automated tests for this, and I'll need to test this manually.

  2. It looks like this change is a breaking change for our agent (since setting baseApiUrl no longer has an effect; I know our probers that run against our test environment will be broken by this). Since we recently bumped out major version (for dropping Node 6), merging this definitely requires careful consideration for us. I don't want to need to bump our major version too frequently.

@bcoe bcoe changed the title feat (breaking!): support API endpoint override feat(breaking)!: support API endpoint override Jun 17, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #509 into master will decrease coverage by 0.19%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #509     +/-   ##
=========================================
- Coverage   76.57%   76.38%   -0.2%     
=========================================
  Files           7        7             
  Lines         269      271      +2     
  Branches       56       56             
=========================================
+ Hits          206      207      +1     
- Misses         48       49      +1     
  Partials       15       15
Impacted Files Coverage Δ
ts/src/config.ts 100% <ø> (ø) ⬆️
ts/src/profiler.ts 89.44% <100%> (+0.13%) ⬆️
ts/src/index.ts 58.69% <50%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ae463...73473ea. Read the comment docs.

@nolanmar511 nolanmar511 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 26, 2019
@nolanmar511
Copy link
Contributor

Added a "do not merge" label because I'd like to get a release of @google-cloud/profiler out before merging this change.

@nolanmar511 nolanmar511 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 27, 2019
@nolanmar511 nolanmar511 requested a review from bcoe June 27, 2019 18:08
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable to me. @nolanmar511, let's try to figure out why release-please is not working on this repo, and release the next version of this library using automation.

@nolanmar511 nolanmar511 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2019
@nolanmar511 nolanmar511 changed the title feat(breaking)!: support API endpoint override feat(breaking!): support API endpoint override Jun 27, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2019
@nolanmar511 nolanmar511 merged commit 9bd110e into master Jun 28, 2019
@nolanmar511 nolanmar511 deleted the common branch April 13, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants