fix: workaround certificate expiration issue in integration tests #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's Encrypt CA certification expiration is causing integration tests to fail. This commit works around this problem by removing the problematic certificate. Context: https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
amchiclet
added
kokoro:run
google-cla
bot
added
the
cla: yes
yoshi-kokoro
removed
the
kokoro:run
nolanmar511
approved these changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## main #773 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 7 7
Lines 1209 1209
Branches 57 57
=======================================
Hits 846 846
Misses 362 362
Partials 1 1 Continue to review full report at Codecov.
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.5](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.1.4...v4.1.5) (2021-10-06) ### Bug Fixes * workaround certificate expiration issue in integration tests ([#773](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/773)) ([9d4908b](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/9d4908b7161e0aade0915d2d88a43b0a6bfc9791)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's Encrypt CA certification expiration is causing integration tests to fail internally.
This commit works around this problem by removing the problematic certificate.
Context: https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/