Skip to content

Commit

Permalink
retry node 18 tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sofisl committed Aug 10, 2023
1 parent e72016e commit aacda85
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions test/test-trace-hapi-tails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ describe('Web framework tracing', () => {

// Skip this set for incompatible versions of Node
const skip = !semver.satisfies(process.version, versionRange);
console.log('READ THESE LOGS --------------->');
console.log(process.version);
console.log(versionRange);
console.log(skip);

(skip ? describe.skip : describe)(`Tracing ${commonName}`, () => {
// How this test works:
Expand Down
4 changes: 2 additions & 2 deletions test/web-frameworks/hapi17.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,5 @@ const makeHapiClass = (version: number, nodeVersionRange: string) =>
}
};

export const Hapi18 = makeHapiClass(18, '>=7.5|| <=18');
export const Hapi19 = makeHapiClass(19, '>=12 || <=18');
export const Hapi18 = makeHapiClass(18, '>=7.5|| <18');
export const Hapi19 = makeHapiClass(19, '>=12 || <18');
2 changes: 1 addition & 1 deletion test/web-frameworks/hapi8_16.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const makeHapiClass = (version: number) =>
class extends Hapi {
static commonName = `hapi@${version}`;
static expectedTopStackFrame = 'handler';
static versionRange = '*';
static versionRange = '<18';

constructor() {
super(`../plugins/fixtures/hapi${version}`);
Expand Down

0 comments on commit aacda85

Please sign in to comment.