Test/fix sed sys variance #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
`sed` was being used in the `http-e2e.js` test with the `-i` flag to perform changes in-place. However, this option has a different syntax on OS X vs Linux. As a fix, `-i.bak` is now used to explicitly specify a backup extension works on both OS X and Linux. The command has been tested on OS X and Debian.
DominicKramer
force-pushed
the
test/fix-sed-sys-variance
branch
from
de6cd05
to
5c1eead
Compare
kjin
approved these changes
Jan 5, 2017
kjin
reviewed
Jan 5, 2017
DominicKramer
force-pushed
the
test/fix-sed-sys-variance
branch
from
31a586b
to
07b508d
Compare
DominicKramer
force-pushed
the
test/fix-sed-sys-variance
branch
from
07b508d
to
b911018
Compare
ofrobots
approved these changes
Jan 5, 2017
DominicKramer
added a commit
to DominicKramer/cloud-trace-nodejs
that referenced
this pull request
Jan 6, 2017
`sed` was being used in the `http-e2e.js` test with the `-i` flag to perform changes in-place. However, this option has a different syntax on OS X vs Linux. As a fix, `-i.bak` is now used to explicitly specify a backup extension works on both OS X and Linux. PR-URL: googleapis#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sedwas being used in thehttp-e2e.jstest with the-iflagto perform changes in-place. However, this option has a different
syntax on OS X vs Linux. As a fix,
-i.bakis now used toexplicitly specify a backup extension works on both OS X and
Linux.
The command has been tested on OS X and Debian.