test: cleanup grpc and http2 tests to minimize flakes #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kjin
force-pushed
the
fix-system-tests-2
branch
2 times, most recently
from
6d83297
to
581b9e6
Compare
kjin
force-pushed
the
fix-system-tests-2
branch
from
581b9e6
to
f57bb0d
Compare
kjin
changed the title
ofrobots
approved these changes
Dec 13, 2018
| assert.ok( | ||
| spanDuration >= bounds[0] && spanDuration <= bounds[1], | ||
| spanDuration >= lowerBound - ASSERT_SPAN_TIME_TOLERANCE_MS && | ||
| spanDuration <= upperBound + ASSERT_SPAN_TIME_TOLERANCE_MS, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpcandhttp2tests fail occasionally on nightly builds because the acceptable range for span time ranges isn't ideal for the CI environment. I've moved them off the oldcommon.assertSpanDurationto the newerutils.assertSpanDurationwhich allows us to use more reasonable time ranges. There is also a bit of minor cleanup involved as somecommon.*values are no longer used anywhere.Note: The
test-trace-http2.tsdiff seems large because of an indentation change, but the tests themselves are the same.