Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make forking functionality optional #101

Merged
merged 3 commits into from
Sep 8, 2020
Merged

feat: make forking functionality optional #101

merged 3 commits into from
Sep 8, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 5, 2020

If you are using secrets.GITHUB_TOKEN or an application JWT, there's no associated GitHub account to fork to.

This feature adds the option to skip forking in these contexts.

@bcoe bcoe requested a review from a team September 5, 2020 02:26
@bcoe bcoe requested a review from a team as a code owner September 5, 2020 02:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 5, 2020
@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   85.69%   85.72%   +0.03%     
==========================================
  Files          14       14              
  Lines        1244     1247       +3     
  Branches       91       84       -7     
==========================================
+ Hits         1066     1069       +3     
  Misses        177      177              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.ts 99.39% <100.00%> (+<0.01%) ⬆️
src/types/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f57c4...15eec18. Read the comment docs.

@bcoe bcoe merged commit 1a25661 into master Sep 8, 2020
@bcoe bcoe deleted the optional-fork branch September 8, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants