fix: range parsing #125
Merged
fix: range parsing #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 91.96% 91.41% -0.55%
==========================================
Files 25 25
Lines 2314 2248 -66
Branches 184 160 -24
==========================================
- Hits 2128 2055 -73
- Misses 185 192 +7
Partials 1 1
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Oct 5, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 7, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/code-suggester/compare/v1.6.0...v1.7.0) (2020-10-07) ### Features * **action:** action can now review pull requests ([#135](https://www.github.com/googleapis/code-suggester/issues/135)) ([c90a128](https://www.github.com/googleapis/code-suggester/commit/c90a128bb4e808ed3a1a8212eb4aac2e1179792d)) * **cli:** add command for reviewing a pr ([#130](https://www.github.com/googleapis/code-suggester/issues/130)) ([ffac451](https://www.github.com/googleapis/code-suggester/commit/ffac45171c68f67c75858866c51cb0dec9993141)) ### Bug Fixes * **action:** default upstream owner/repo to the current repo ([#131](https://www.github.com/googleapis/code-suggester/issues/131)) ([3dd762a](https://www.github.com/googleapis/code-suggester/commit/3dd762a49f6c42b6a652f3420d842a43f3744c3f)), closes [#73](https://www.github.com/googleapis/code-suggester/issues/73) * handle single line comments and add newline ([#128](https://www.github.com/googleapis/code-suggester/issues/128)) ([1526a40](https://www.github.com/googleapis/code-suggester/commit/1526a40de4d18765fc9343356f2be70e9af068a2)) * range parsing ([#125](https://www.github.com/googleapis/code-suggester/issues/125)) ([4993d62](https://www.github.com/googleapis/code-suggester/commit/4993d62f3e37d23b3cda83516c2dc6879464132f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change looks at the diff contents to calculate the start/end line numbers. We exclude "normal" lines which are the untouched lines in the diff to calculate the start/end line numbers.
Adjusts the expected test lines as they were invalid.
Fixes #124