Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: git diff-raw may have changed formats #229

Closed
chingor13 opened this issue May 26, 2021 · 3 comments · Fixed by #334 or #336
Closed

action: git diff-raw may have changed formats #229

chingor13 opened this issue May 26, 2021 · 3 comments · Fixed by #334 or #336
Assignees
@chingor13
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

The step may have failed, but was marked as success: https://github.com/googleapis/google-cloud-node/runs/2677193976?check_suite_focus=true
@chingor13 chingor13 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 26, 2021
@chingor13 chingor13 self-assigned this May 26, 2021
@chingor13
Copy link
Contributor Author

This error appears to be when there are no changes in the local git directory.

@chingor13 chingor13 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 24, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 20, 2022
@chingor13
Copy link
Contributor Author

We will reopen this if we see it again

@chingor13
Copy link
Contributor Author

This still happens

@chingor13 chingor13 reopened this Feb 23, 2022
@chingor13 chingor13 mentioned this issue Feb 23, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 23, 2022
@chingor13
fix(cli): don't crash when there are no changes (#334)
e606126 
code-suggester CLI is trying to parse an empty string as a valid file diff and crashing.

Fixes #229
@release-please release-please bot mentioned this issue Feb 23, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 23, 2022
@release-please
chore(main): release 2.1.4 (#336)
7ef2240 
🤖 I have created a release *beep* *boop*
---


### [2.1.4](v2.1.3...v2.1.4) (2022-02-23)


### Bug Fixes

* **cli:** don't crash when there are no changes ([#334](#334)) ([e606126](e606126)), closes [#229](#229)
* try to merge the upstream repo branch on the fork ([#330](#330)) ([2d5c3f9](2d5c3f9)), closes [#335](#335)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @yoshi-automation