-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a branch from origin owner, repo, branch name, and an optional primary branch #27
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
===========================================
+ Coverage 44.69% 58.36% +13.67%
===========================================
Files 6 7 +1
Lines 179 281 +102
Branches 4 11 +7
===========================================
+ Hits 80 164 +84
- Misses 99 117 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
This PR implements the basic functionality of creating a branch and has basic mock test.
Given:
Correctly create a new GitHub reference based off the primary branch HEAD SHA.
On successful reference creation, the GitHub API (wrapped by Octokit) returns the base SHA for new commits to be applied on top of.
On GitHub API error, log error and re-throw the error. On primary branch not found error, throw that error.
This PR also groups repository domain data together, and reverts accidental
.gitattribute
andsynth.metadata
changesTowards #19