Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-line PR code suggestion comments #59

Closed
4 tasks
TomKristie opened this issue Aug 4, 2020 · 1 comment
Closed
4 tasks

Support multi-line PR code suggestion comments #59

TomKristie opened this issue Aug 4, 2020 · 1 comment
Assignees
@TomKristie
Labels
type: process A process-related concern. May include testing, release, or the like.
Milestone
Allow framework-c...

Comments

@TomKristie
Copy link
Contributor

Create (a) function(s) in the

  • framework-core
  • CLI

where it takes as input

  • the complete file content changeset is taken as input
  • gnu diff string is taken as input

and automatically creates a PR code-suggestion comment, (see step 6)

  • supports multi-line comments
  • preserve framework-core independence from git
@TomKristie TomKristie added the type: process A process-related concern. May include testing, release, or the like. label Aug 4, 2020
@TomKristie TomKristie self-assigned this Aug 4, 2020
@TomKristie TomKristie mentioned this issue Aug 5, 2020
Closed
This was referenced Aug 14, 2020
Closed
Merged
Merged
Merged
Merged
Merged
@TomKristie TomKristie mentioned this issue Aug 21, 2020
Merged
2 tasks
@KristieTom12
Copy link

@chingor13 Great work! What's the status on the comment-pr branch? This work is on the comment-pr branch only.

@KristieTom12 KristieTom12 mentioned this issue Sep 8, 2020
Closed
@TomKristie TomKristie mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomKristie TomKristie

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
Allow framework-core to comment on PRs
Development

No branches or pull requests
3 participants
@chingor13 @KristieTom12 @TomKristie