-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework-core): hunk to patch object #91
fix(framework-core): hunk to patch object #91
Conversation
Codecov Report
@@ Coverage Diff @@
## comment-pr #91 +/- ##
=============================================
Coverage ? 85.75%
=============================================
Files ? 22
Lines ? 1966
Branches ? 131
=============================================
Hits ? 1686
Misses ? 279
Partials ? 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a note/issue to investigate refactoring to parsing the original diff. If the source file is huge, we are loading the entire file into memory.
…n pull requests (#105) * feat(patch text to hunk bounds): support regex for patch texts (#83) * fix(patch text to hunk bounds): support regex for patch texts * more comments and more tests * fix(framework-core): core-library get remote patch ranges (#84) * fix(framework-core): given files old content and new content, compute the valid hunks (#86) * fix(framework-core): parse raw changes to ranges * refactor(framework-core): rename modules, functions, & re-org project structure (#89) * fix(framework-core): hunk to patch object (#91) * feat: build failure message from invalid hunks (#90) * test: add failing stub and test for building the failure message * fix: implement message building * fix: use original line numbers in error message * docs: add docstring * docs: add note about empty input returning empty string * feat(framework-core): comment on prs given suggestions (#93) * feat(framework-core): main interface for create review on a pull request (#114) * feat(framework-core): main interface for create review on a pull request * docs: fix typo * nits and typos... * gts lint warning fix * fix(framework-core): combine review comments (#116) * fix(framework-core): collapsing timeline and inline comments into single review * test: fixed imports * added case when there are out of scope suggestions and no valid suggestions * feat(framework-core): return review number and variable renaming (#117) * feat(framework-core): return review number and variable renaming * lint Co-authored-by: Jeff Ching <chingor@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
From the calculated in scope suggestion hunks, or rather for what can be suggested to the remote PR, gather the new raw text and pair it with the older version of text. Recall the older version of text matches the remote content. Therefore, find the valid hunks to suggest and pair it with its updated comment.
We assume all lines to be >= 1 since the diff library calculates our lines and has this feature. If it is not we throw an error (which should never happen but just in case)
Towards #59 🦕