Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add ci scripts #1

Merged
merged 6 commits into from
Jul 11, 2019
Merged

Add ci scripts #1

merged 6 commits into from
Jul 11, 2019

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 9, 2019

Adding some basic kokoro builds for now. We'll add more tests with #2 and #3.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you for starting this work. I left a bunch of comments inline.
In addition:

  • Can we move the .cfg files to ci/kokoro/docker/?
  • The CI compiles the code, but I do not think we test the install target for our libraries. We should, but that can be in a future PR.

Note that testing install is more than just running make install, we also want to verify the installed headers and libraries are usable, i.e., we need to compile, link and run a test program against said libraries.

@scotthart just FYI, note how we now have 3 copies of the scripts to drive the CI builds. A better way does not immediately come to mind, but this is what I mean by we need to design that part of the multi-repository thing.

ci/kokoro/dump-logs.sh Outdated Show resolved Hide resolved
ci/kokoro/docker/build.sh Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
ci/kokoro/Dockerfile.ubuntu Outdated Show resolved Hide resolved
ci/install-grpc.sh Outdated Show resolved Hide resolved
ci/install-grpc.sh Outdated Show resolved Hide resolved
ci/install-grpc.sh Outdated Show resolved Hide resolved
ci/install-grpc.sh Outdated Show resolved Hide resolved
ci/install-grpc.sh Outdated Show resolved Hide resolved
ci/kokoro/docker/build.sh Show resolved Hide resolved
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 10, 2019

@coryan Thanks, I think I addressed all the comments. PTAL

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, please fix before merging.

Do we need a common.cfg file like this one?

https://github.com/googleapis/google-cloud-cpp/blob/master/ci/kokoro/docker/common.cfg

ci/kokoro/Dockerfile.ubuntu Show resolved Hide resolved
ci/kokoro/docker/build.sh Outdated Show resolved Hide resolved
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 11, 2019

@coryan Thanks, I added common.cfg, merging

@tmatsuo tmatsuo merged commit aefb8c9 into googleapis:master Jul 11, 2019
@tmatsuo tmatsuo deleted the add-ci branch July 11, 2019 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants