This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
cleanup: refactor single-source library definitions. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of the libraries have a single source and can be refactored to a function that creates them.
googlebot
added
the
cla: yes
mr-salty
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @coryan, @devbww, @devjgm, @mr-salty, @scotthart, and @tmatsuo)
CMakeLists.txt, line 140 at r1 (raw file):
endfunction () function (googleapis_cpp_add_library proto)
Add a comment that there are additional arguments [public_deps...] ? IDK what the common CMake style is here but it threw me for a loop at first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the libraries have a single source and can be refactored to a
function that creates them.