Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add install test #8

Merged
merged 6 commits into from
Jul 16, 2019
Merged

Add install test #8

merged 6 commits into from
Jul 16, 2019

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 15, 2019

Fixes #2

Added distros:

  • centos-7
  • fedora-30
  • opensuse-leap
  • opensuse-tumbleweed
  • ubuntu-16.04
  • ubuntu-18.04

Also testing shared lib with fedora 30.

A script for rendering INSTALL.md will come with another PR.

@tmatsuo tmatsuo added testing do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 15, 2019
@tmatsuo tmatsuo requested a review from coryan July 15, 2019 17:49
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the suggestions below. Even without them this is an improvement over what we have, though with those suggestions the test is (I think) better.

ci/install/CMakeLists.txt Outdated Show resolved Hide resolved
ci/install/CMakeLists.txt Outdated Show resolved Hide resolved
ci/install/main.cc Outdated Show resolved Hide resolved
ci/install/main.cc Outdated Show resolved Hide resolved
ci/kokoro/install/build.sh Outdated Show resolved Hide resolved
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 16, 2019

@coryan Thanks! I pushed the new changes to the personal branch, and I updated the PR description. Weirdly the PR is not updated with the latest change. I'll wait a bit more.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 16, 2019

@coryan The changes are now reflected. PTAL (for the last two commits)

@tmatsuo tmatsuo merged commit 08ce6e0 into googleapis:master Jul 16, 2019
@tmatsuo tmatsuo deleted the install-test branch July 16, 2019 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test make install in the kokoro tests
2 participants