This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
added
testing
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Jul 15, 2019
coryan
reviewed
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the suggestions below. Even without them this is an improvement over what we have, though with those suggestions the test is (I think) better.
coryan
approved these changes
Jul 15, 2019
@coryan Thanks! I pushed the new changes to the personal branch, and I updated the PR description. Weirdly the PR is not updated with the latest change. I'll wait a bit more. |
@coryan The changes are now reflected. PTAL (for the last two commits) |
coryan
approved these changes
Jul 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Added distros:
Also testing shared lib with fedora 30.
A script for rendering
INSTALL.md
will come with another PR.