We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a request message appears in a discovery doc, for example:
message InsertForwardingRuleRequest { "insert": { //... "request": { "@ref": "ForwardingRule" } //... } //... }
This generates a request message with that resource on it:
message InsertForwardingRuleRequest { ForwardingRule forwarding_rule_resource = 32776239; //... }
However, the required annotation is missing in the proto. As a result, the call in GAPIC PHP looks like the following:
$optionalParams = ['forwardingRule' => $forwardingRule]; $forwardingRulesClient->insert('project', 'region', $optionalParams);
When it would be better as this:
$optionalParams = []; $forwardingRulesClient->insert('project', 'region', $forwardingRules, $optionalParams);
We should verify with the API teams that any message in a request body is required.
The text was updated successfully, but these errors were encountered:
Fixed in #21
Sorry, something went wrong.
bshaffer
No branches or pull requests
When a request message appears in a discovery doc, for example:
This generates a request message with that resource on it:
However, the required annotation is missing in the proto. As a result, the call in GAPIC PHP looks like the following:
When it would be better as this:
We should verify with the API teams that any message in a request body is required.
The text was updated successfully, but these errors were encountered: