feat: support API versioning in generated protos #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the methods that wind up in a each proto service all have the same "apiVersion" field in the Discovery document, that value becomes part of a new "api_version" annotation in the proto service. If the version numbers for the methods in a service don't match, generation fails.
vchudnov-g
force-pushed
the
diregapic-apiversion
branch
from
813b0dd
to
b4d2c8d
Compare
parthea
approved these changes
Apr 7, 2024
| // This method returns the same as parseMethods(), but returns all methods in a map indexed by | ||
| // method name. | ||
| // | ||
| // TODO: Combine with parseMethods? |
There was a problem hiding this comment.
Suggested change
| // TODO: Combine with parseMethods? | |
| // TODO: See <REPLACE ME with link to new bug filed in https://github.com/googleapis/disco-to-proto3-converter/issues> |
Same applies to the 2nd TODO comment in this PR
| @@ -0,0 +1,761 @@ | |||
| // Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2020 Google LLC | |
| // Copyright 2024 Google LLC |
There was a problem hiding this comment.
The date is derived from the Discovery revision field, so this is WAI. But to your point, since these Discovery fragments are new, I'll change them to have a 2024 date.
| } | ||
|
|
||
| @Test | ||
| public void convertVersionedInconsistent() throws IOException { |
There was a problem hiding this comment.
nit: Add a comment under each test which explains the purpose of each test
|
I don't know enough about this generator to give detailed feedback, but it looks fine to me. |
parthea
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the methods that wind up in a each proto service all have the same "apiVersion" field in the Discovery document, that value becomes part of a new "api_version" annotation in the proto service. If the version numbers for the methods in a service don't match, generation fails.