Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding single language build support #44

Merged
merged 6 commits into from Dec 9, 2020
Merged

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Dec 2, 2020

By specifying "LANGUAGE=", users can build only that individual language.

Fixes #40

By specifying "LANGUAGE=", users can build only that individual language.
@dandhlee dandhlee requested a review from tbpg December 2, 2020 23:39
@dandhlee dandhlee requested a review from a team as a code owner December 2, 2020 23:39
@dandhlee dandhlee self-assigned this Dec 2, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@dandhlee
Copy link
Contributor Author

dandhlee commented Dec 2, 2020

The code has been tested by:

  1. Copying some docfx resources from gs://docs-staging-v2
    with gsutil -m cp gs://docs-staging-v2/* gs://test-bucket-pipeline

  2. with the added "language" support, confirmed the following:

  • specifying java and go returns no blobs to build
  • specifying nodejs processes 3 blobs, python for 38 blobs
  1. ran the command locally:
    SOURCE_BUCKET=test-bucket-pipeline LANGUAGE=python TRAMPOLINE_BUILD_FILE=./generate.sh TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/docfx TRAMPOLINE_DOCKERFILE=docfx/Dockerfile ci/trampoline_v2.sh
    with language differing for each run.

Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like you need to format the files. From the Kokoro log:

2 files would be reformatted, 2 files would be left unchanged.

See https://github.com/googleapis/doc-pipeline#formatting-and-style -- hopefully that works.

.trampolinerc Show resolved Hide resolved
docpipeline/generate.py Show resolved Hide resolved
@dandhlee dandhlee requested a review from tbpg December 3, 2020 19:13
@dandhlee
Copy link
Contributor Author

dandhlee commented Dec 3, 2020

All tests have passed, will check with black more frequently to avoid build errors.
Updated README
Added new test for language specific builds

@tbpg tbpg merged commit 95977aa into master Dec 9, 2020
@tbpg tbpg deleted the build_each_language branch December 9, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow regenerating all HTML for a single language
2 participants