Ensure Storage.object parameter encodes "/" chars (#6510) #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Simple exemption for that parameter, since it appears to be the only one affected. Update unit test to check for properly encoded object parameter (note that it matches what `gsutil -D rm ...` is doing). Issue googleapis#6352 is probably a duplicate of googleapis#6510.
|
Anything I can do to help get this reviewed? |
dazuma
approved these changes
Mar 9, 2021
|
@dazuma I think this is still broken for storage_objects_copy and storage_objects_rewrite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple exemption for the Storage
objectparameter to not treat it as a "path trailer" parameter.Issue reported in #6510
Background
Changes released in v0.24 (PR 5869 for Issue #4600) allow a parameter, if the last one in a path, to not URI.encode() the path separator (
/).However, the Storage API requires the
objectparameter to have path separator characters encoded, even though it is the last parameter in a URL path.Since this seems to be the only API people have reported about, I've added a specific exception for the Storage
objectparameter to make sure it gets the full URI encoding.Also closes #6352, which I believe is a duplicate of #6510.