Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retry with only timeout specified #257

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

chrisdunelm
Copy link
Contributor

Fixes #256

@chrisdunelm chrisdunelm requested a review from jskeet June 17, 2020 13:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2020
@chrisdunelm chrisdunelm merged commit 3d66a11 into googleapis:master Jun 17, 2020
@chrisdunelm chrisdunelm deleted the retryfix branch June 17, 2020 15:55
jskeet added a commit to jskeet/google-cloud-dotnet that referenced this pull request Jun 17, 2020
This effectively applies
googleapis/gapic-generator-csharp#257, which
enables RPCs without retries to still have timeouts specified.

It is expected that change (along with synth.metadata changes) should
be the *only* change in this PR.
jskeet added a commit to googleapis/google-cloud-dotnet that referenced this pull request Jun 17, 2020
This effectively applies
googleapis/gapic-generator-csharp#257, which
enables RPCs without retries to still have timeouts specified.

It is expected that change (along with synth.metadata changes) should
be the *only* change in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout is not applied when there's no retry policy
3 participants