Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gengapic): separate repeated prim qp values #1161

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

noahdietz
Copy link
Collaborator

For REGAPIC query params, repeated non-message fields should be included in the query params as multiple, individual key-value pairs using the same field name as the key and each item in the slice as a singular value.

Fixes #1160

@noahdietz noahdietz marked this pull request as ready for review October 20, 2022 18:02
@noahdietz noahdietz requested review from a team as code owners October 20, 2022 18:02
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz merged commit f2edb34 into googleapis:main Oct 21, 2022
@noahdietz noahdietz deleted the regapic-repeated-qp branch October 21, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants