fix(internal/gengapic): write snippet output to cloud.google.com/go #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Write snippets at the top level of the google-cloud-go namespace.
|
Draft, pending manual testing with OwlBot |
noahdietz
approved these changes
Apr 21, 2023
Comment on lines
+141
to
+149
| func (g *generator) snippetsOutDir() string { | ||
| if strings.Contains(g.opts.pkgPath, "cloud.google.com/go/") { | ||
| // Write snippet metadata at the top level of the google-cloud-go namespace, not at the client package. | ||
| // This matches the destination directory structure in google-cloud-go. | ||
| pkg := strings.TrimPrefix(g.opts.pkgPath, "cloud.google.com/go/") | ||
| return filepath.Join("cloud.google.com/go", "internal", "generated", "snippets", filepath.FromSlash(pkg)) | ||
| } | ||
| return filepath.Join(g.opts.outDir, "internal", "snippets") | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deep-copy-regexin.OwlBot.yaml, both client files and snippets are copied to the correct destinations in google-cloud-go. (deep-remove-regexwill also need to be updated to remove deleted snippets.)Results from `bazelisk build //google/cloud/asset/v1:gapi-cloud-asset-v1-go`
Results from `docker run --rm --user$(id -u):$ (id -g) -v $GOOGLE_CLOUD_GO:/repo -v $GOOGLEAPIS/bazel-bin:/bazel-bin gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin --config-file=.github/.OwlBot.yaml --source-dir /bazel-bin --dest /repo`