Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gengapic): add workaround for operation collision #1397

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix(internal/gengapic): add workaround for operation collision #1397

merged 3 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. fix(internal/gengapic): add workaround for operation collision 

    We have a service that is not yet released that uses the same RPC
name across two services in the same proto package. Our Operation
wrapper identifiers are not scoped to a service so this causes
issues when generated a client that does this. For now this is for
one client, which may change before GA, so a hacky solution is fine.
But we should keep this in the back of our minds should we ever v2
our libraries this is something we would want to avoid.
    @codyoss
    codyoss committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5ae7564 View commit details
    Browse the repository at this point in the history

  2. add missing dep

    @codyoss
    codyoss committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8beace4 View commit details
    Browse the repository at this point in the history

  3. add more context

    @codyoss
    codyoss committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d1e8063 View commit details
    Browse the repository at this point in the history