Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SampleComposer, Sample, Region Tag (pt1) #933

Merged
merged 10 commits into from Mar 17, 2022
Merged

feat: SampleComposer, Sample, Region Tag (pt1) #933

merged 10 commits into from Mar 17, 2022

Conversation

eaball35
Copy link
Contributor

go/java-sample-gen

@eaball35 eaball35 requested review from a team as code owners February 15, 2022 03:49
@snippet-bot
Copy link

snippet-bot bot commented Feb 15, 2022

Here is the summary of possible violations 😱

There are 5 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #933 (b1279e6) into main (03fba01) will decrease coverage by 0.51%.
The diff coverage is 95.45%.

❗ Current head b1279e6 differs from pull request most recent head e238a0f. Consider uploading reports for the commit e238a0f to get more accurate results

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   87.96%   87.44%   -0.52%     
==========================================
  Files         156      165       +9     
  Lines       16198    16435     +237     
  Branches     1179     1182       +3     
==========================================
+ Hits        14248    14372     +124     
- Misses       1608     1721     +113     
  Partials      342      342              
Impacted Files Coverage Δ
...n/java/com/google/api/generator/ProtoRegistry.java 0.00% <0.00%> (ø)
...i/generator/engine/writer/ImportWriterVisitor.java 93.30% <ø> (+0.35%) ⬆️
...mposer/samplecode/SampleCodeBodyJavaFormatter.java 100.00% <ø> (ø)
...om/google/api/generator/gapic/model/RegionTag.java 82.35% <82.35%> (ø)
...ator/gapic/composer/samplecode/SampleComposer.java 97.80% <97.80%> (ø)
...erator/gapic/composer/comment/CommentComposer.java 92.85% <100.00%> (+5.35%) ⬆️
...or/gapic/composer/samplecode/SampleCodeWriter.java 90.90% <100.00%> (+3.40%) ⬆️
...a/com/google/api/generator/gapic/model/Sample.java 100.00% <100.00%> (ø)
...pi/generator/debug/CodeGeneratorRequestDumper.java 0.00% <0.00%> (ø)
...java/com/google/api/generator/gapic/Generator.java 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6a02f...e238a0f. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

97.4% 97.4% Coverage
0.0% 0.0% Duplication

@eaball35 eaball35 requested a review from blakeli0 March 16, 2022 22:39
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eaball35 eaball35 merged commit b7cf105 into main Mar 17, 2022
@eaball35 eaball35 deleted the samplegen-pt1 branch March 17, 2022 16:56
suztomo pushed a commit that referenced this pull request Dec 16, 2022
* feat: SampleComposer, Sample, Region Tag

* chore: update sample formatter name

* refactor: writing

* refactor: include sync/async region tag attribute

* refactor: naming updates

* refactor: update naming - tests

* chore: update formatter regex

Security Hotspot

* chore: update regex

be more explicit
suztomo pushed a commit that referenced this pull request Mar 21, 2023
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants