-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SampleComposer, Sample, Region Tag (pt1) #933
Conversation
Here is the summary of possible violations 😱 There are 5 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
==========================================
- Coverage 87.96% 87.44% -0.52%
==========================================
Files 156 165 +9
Lines 16198 16435 +237
Branches 1179 1182 +3
==========================================
+ Hits 14248 14372 +124
- Misses 1608 1721 +113
Partials 342 342
Continue to review full report at Codecov.
|
src/main/java/com/google/api/generator/gapic/model/RegionTag.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/gapic/composer/samplecode/SampleComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/gapic/composer/samplecode/SampleComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/gapic/composer/samplecode/SampleComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/gapic/composer/samplecode/SampleComposer.java
Outdated
Show resolved
Hide resolved
Security Hotspot
be more explicit
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: SampleComposer, Sample, Region Tag * chore: update sample formatter name * refactor: writing * refactor: include sync/async region tag attribute * refactor: naming updates * refactor: update naming - tests * chore: update formatter regex Security Hotspot * chore: update regex be more explicit
Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
go/java-sample-gen