[composer][samplecode]Add writeSampleCode method #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summer-ji-eng
requested review from
miraleung and
xiaozhenliu-gg5
as code owners
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
This was referenced Nov 17, 2020
xiaozhenliu-gg5
approved these changes
Nov 17, 2020
miraleung
suggested changes
Nov 17, 2020
src/main/java/com/google/api/generator/gapic/composer/samplecode/SampleCodeWriter.java
Outdated
Show resolved
Hide resolved
| assertEquals(expected, result); | ||
| } | ||
|
|
||
| private AssignmentExpr createAssignmentExpr(String varName, String varValue, TypeNode type) { |
There was a problem hiding this comment.
Nit: Since there is only one usage of this method, let's just call the internals directly and forego this wrapper.
There was a problem hiding this comment.
There are two usage above. Line 57, and line 58. I suggest to use the wrapper make the code clean.
miraleung
approved these changes
Nov 17, 2020
suztomo
added a commit
that referenced
this pull request
Dec 16, 2022
Co-authored-by: Jeffrey Rennie <rennie@google.com> Co-authored-by: Tomo Suzuki <suztomo@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/b59cf7b5a91ecab29e21fdfbb7e3b81066229be4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:894d56f45fc3f4f0d5f3bcf790846419ee2d8e44715eae8917d6a1bba2b7283d
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper function to writeSampleCode where it has been frequently used in #487 #493 #498 and future changes.