Add support for grpc only gapic

googleapis · Apr 23, 2024 · 8355a80 · 8355a80
1 parent 46dc31c
commit 8355a80
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/rules_php_gapic/php_gapic.bzl b/rules_php_gapic/php_gapic.bzl
@@ -69,9 +69,7 @@ def php_gapic_srcjar(
     # Transport.
     if transport == None:
         transport = "grpc+rest"
-    if transport == "grpc":
-        fail("Error: gRPC-only PHP GAPIC libraries are not yet supported")
-    if transport != "grpc+rest" and transport != "rest":
+    if transport != "grpc+rest" and transport != "rest" and transport != "grpc":
         fail("Error: Only 'grpc+rest' or 'rest' transports are supported")
 
     # Set plugin arguments.

diff --git a/src/Generation/GapicClientV2Generator.php b/src/Generation/GapicClientV2Generator.php
@@ -478,15 +478,23 @@ private function defaultTransport()
 
     private function supportedTransports()
     {
-        if ($this->serviceDetails->transportType !== Transport::REST) {
-            return null;
-        }
-        return AST::method('supportedTransports')
-            ->withPhpDocText('Implements GapicClientTrait::supportedTransports.')
+        if ($this->serviceDetails->transportType === Transport::REST) {
+            return AST::method('supportedTransports')
+            ->withPhpDocText('Implements ClientOptionsTrait::supportedTransports.')
             ->withAccess(Access::PRIVATE, Access::STATIC)
             ->withBody(AST::block(
                 AST::return(AST::array(['rest']))
             ));
+        }
+
+        if ($this->serviceDetails->transportType === Transport::GRPC) {
+            return AST::method('supportedTransports')
+            ->withPhpDocText('Implements ClientOptionsTrait::supportedTransports.')
+            ->withAccess(Access::PRIVATE, Access::STATIC)
+            ->withBody(AST::block(
+                AST::return(AST::array(['grpc', 'grpc-fallback']))
+            ));
+        }
     }
 
     private function construct(): PhpClassMember

diff --git a/src/Utils/Transport.php b/src/Utils/Transport.php
@@ -24,6 +24,7 @@ class Transport
     // supported in the future (e.g. gRPC only).
     public const GRPC_REST = 1;
     public const REST = 2;
+    public const GRPC = 3;
 
     /**
      *  Returns true if the given transport string indicates that grpc+rest transports