fix: prevent duplicate fragment gen #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
approved these changes
Nov 3, 2023
|
If it's not too difficult, I'd love to see a test for this! |
We don't have any unit tests for this code, but there is one integration test. I will add one with the API that this fix is for once it is in googleapis, if that is OK. |
noahdietz
added
the
automerge
fwiw I did test it locally against the offending API |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [1.9.2](https://togithub.com/googleapis/gapic-generator-php/compare/v1.9.1...v1.9.2) (2023-11-03) ### Bug Fixes * Prevent duplicate fragment gen ([#669](https://togithub.com/googleapis/gapic-generator-php/issues/669)) ([b25acf0](https://togithub.com/googleapis/gapic-generator-php/commit/b25acf0a88daad899a7b30956d9ac3f537eb5ac6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents duplicate generation of fragments for RPCs that share a request message (not common, but possible).