feat: Enable UUID auto-generation for fields listed for auto population in service.yaml #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add methodSettings to ServiceYamlConfig and read them it present * Add ServiceYamlConfig to ServiceDetails and update the constructor.
This reverts commit 6dd397f.
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
yash30201
commented
Feb 26, 2024
noahdietz
reviewed
Feb 27, 2024
noahdietz
reviewed
Feb 27, 2024
yash30201
force-pushed
the
auto-population-request-id-a1
branch
from
cfa19ac
to
82032d1
Compare
bshaffer
reviewed
Feb 28, 2024
noahdietz
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Looks great @yash30201 well done. Resolve @bshaffer 's comments and we can merge this.
yash30201
force-pushed
the
auto-population-request-id-a1
branch
from
f05f621
to
9b6c107
Compare
bshaffer
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Field Auto Population
Implement go/php-auto-population-request-id design resulting in descriptor config generation for rpc fields (if set for auto population in
service.yamlconfiguration). Logic adheres to AIP 155 and AIP 4235.Gax PHP is responsible to do the actual auto population reading the configuration from descriptor config. See b/318607731 for more information.