Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add patches for bigtable required to optional changes #702

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

bshaffer
Copy link
Contributor

See googleapis/google-cloud-php#7118

Recent Bigtable changes have broken BC for the V1 clients because of moving multiple RPC signatures from required to optional. This PR adds patches to revert those changes for the PHP V1 generator.

@bshaffer bshaffer merged commit 207191c into main Apr 12, 2024
5 checks passed
@bshaffer bshaffer deleted the bshaffer-patch-1 branch April 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants