fix: optional-to-required field for Cloud DMS #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
| @@ -138,15 +138,16 @@ class FieldDetails | |||
| * AFTER a package's 1.0 release, back to being optional. | |||
| */ | |||
| private static $optionalToRequiredFixes = [ | |||
| 'google.logging.v2.UpdateCmekSettingsRequest' => ['name', 'cmek_settings'], | |||
| 'google.logging.v2.GetCmekSettingsRequest' => ['name'], | |||
| 'google.cloud.clouddms.v1.DescribeDatabaseEntitiesRequest' => ['tree'], | |||
There was a problem hiding this comment.
What is the tree part and where is it used?
There was a problem hiding this comment.
I don't know anything about it other than it's a property that used to be optional and now it's required.
vishwarajanand
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BC-breaking changes in googleapis/google-cloud-php#6607
Also organizes array values alphabetically for readability