Suggestions from code review for gRPC-only feature #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
commented
Apr 25, 2024
| @@ -443,7 +443,7 @@ private function getClientDefaults(): PhpClassMember | |||
|
|
|||
| // TODO: Consolidate setting all the known array values together. | |||
| // We do this here to maintain the existing sensible ordering. | |||
| if ($this->serviceDetails->transportType !== Transport::REST) { | |||
| if ($this->serviceDetails->transportType === Transport::GRPC_REST) { | |||
There was a problem hiding this comment.
reverting this change simply because GapicClientGenerator is considered "deprecated". But this isn't harming anyone how it was.
bshaffer
commented
Apr 25, 2024
| @@ -220,6 +220,7 @@ php_gapic_library( | |||
| srcs = ["@com_google_googleapis//google/cloud/functions/v1:functions_proto_with_info"], | |||
| grpc_service_config = "@com_google_googleapis//google/cloud/functions/v1:functions_grpc_service_config.json", | |||
| migration_mode = "NEW_SURFACE_ONLY", | |||
| transport = "grpc", | |||
There was a problem hiding this comment.
Moved the "grpc-only" client to be Functions instead of Redis, since now it must be a library marked as NEW_SURFACE_ONLY
bshaffer
commented
Apr 25, 2024
| @@ -71,12 +71,14 @@ def php_gapic_srcjar( | |||
| transport = "grpc+rest" | |||
| if transport != "grpc+rest" and transport != "rest" and transport != "grpc": | |||
| fail("Error: Only 'grpc+rest', 'rest' or `grpc` transports are supported") | |||
| if transport == "grpc" and migration_mode != "NEW_SURFACE_ONLY": | |||
| fail("Error: 'grpc' transport is only supported with 'NEW_SURFACE_ONLY' migration mode") | |||
There was a problem hiding this comment.
this ensures that the previous client surfaces (e.g. GapicClientGenerator, as opposed to GapicClientV2Generator) are not able to be generated with "grpc-only" transport, for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review for #707