fix: Check for default value presence for non-optional fields in REST (…

…#868)
googleapis · May 7, 2021 · 5748001 · 5748001
1 parent 5339db1
commit 5748001
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2
@@ -195,14 +195,15 @@ class {{ service.name }}RestTransport({{ service.name }}Transport):
         if {{ method.input.ident }}.{{ field }} in request:
             query_params['{{ field|camel_case }}'] = request.{{ field }}
         {% else %}
-        query_params['{{ field|camel_case }}'] = request.{{ field }}
+        if request.{{ field }}:
+            query_params['{{ field|camel_case }}'] = request.{{ field }}
         {% endif %}
         {% endfor %}
 
         # TODO(yon-mg): further discussion needed whether 'python truthiness' is appropriate here
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
-        query_params = ['{k}={v}'.format(k=k, v=v) for k, v in query_params.items() if v]
+        query_params = ['{k}={v}'.format(k=k, v=v) for k, v in query_params.items()]
         url += '?{}'.format('&'.join(query_params)).replace(' ', '+')
 
         # Send the request