Skip to content

Commit

Permalink
fix: unit test generation for boolean query prams (#1447)
Browse files Browse the repository at this point in the history
Without this fix the current compute engine tests are failing. Also 3 other APIs in googleapis would have failed if grpc+rest transport was enabled on them.
  • Loading branch information
vam-google committed Sep 13, 2022
1 parent 8e4e209 commit dd68dd1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1213,6 +1213,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
"{{ req_field.name | camel_case }}",
{% if req_field.field_pb.type == 9 %}
"{{ req_field.field_pb.default_value }}",
{% elif req_field.field_pb.type == 8 %}
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
{% else %}
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
{% endif %}{# default is str #}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,8 @@ def test_{{ method_name }}_rest_required_fields(request_type={{ method.input.ide
"{{ req_field.name | camel_case }}",
{% if req_field.field_pb.type == 9 %}
"{{ req_field.field_pb.default_value }}",
{% elif req_field.field_pb.type == 8 %}
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}).lower(),
{% else %}
str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}),
{% endif %}{# default is str #}
Expand Down

0 comments on commit dd68dd1

Please sign in to comment.