-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for MixIns. #1240
Conversation
I will fix integration tests after an LGTM - just need to regenerate golden files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with few comments. Also please regenerate the golden tests.
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/base.py.j2
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/_mixins.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please comment out the exposed operation_client
as per our discussion (and Noah seems to be ok with it). We can always put it back easily if it turns out to be necessary.
MixIn methods include LRO, IAM and Location. Python GAPIC currently supports APIs that use LRO and IAM.
In this PR:
This PR notably does not remove support for
optis.add_iam_methods
flag. I will do so in the subsequent PR to avoid breaking users. Current implementation adds iam methods once only if either theadd_iam_methods
or it was included in service YAML.Note: this adds a new dependency to the generator (
grpc-google-iam-v1
)