Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wildcard resource names helper method #1363

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

vam-google
Copy link
Contributor

This fixes #1358

@vam-google vam-google requested review from a team as code owners July 20, 2022 21:30
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 20, 2022
@vam-google vam-google requested a review from parthea July 20, 2022 21:32
@parthea
Copy link
Contributor

parthea commented Jul 21, 2022

LGTM once tests pass

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 21, 2022
@vam-google vam-google merged commit b4ecb44 into googleapis:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asterisk resource names result into broken resource name helper method
2 participants