Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(client): Fix typo in get_mtls_endpoint_and_cert_source doc #1552

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Jan 4, 2023

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea Not necessary IMO, this is just a typo fix
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) N/A
  • Appropriate docs were updated (if necessary) This is a doc fix

Opening here instead of in python-firestore as requested on googleapis/python-firestore#672

@rwhogg rwhogg requested review from a team as code owners January 4, 2023 21:50
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 4, 2023
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the golden files to resolve CI failures:
https://github.com/googleapis/gapic-generator-python/blob/main/DEVELOPMENT.md#integration-tests

Run

bazel run //tests/integration:asset_update
bazel run //tests/integration:credentials_update
bazel run //tests/integration:eventarc_update
bazel run //tests/integration:logging_update
bazel run //tests/integration:redis_update

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 5, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2023
@parthea parthea enabled auto-merge (squash) January 5, 2023 17:34
@parthea parthea merged commit 57e8abc into googleapis:main Jan 5, 2023
@rwhogg rwhogg deleted the typo-fix branch January 5, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants