Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where rest test appears in grpc-only client #1343

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

atulep
Copy link
Contributor

@atulep atulep commented Jun 28, 2022

Some APIs are failing with errors related to rest transport.

This is because one of the tests is missing conditional check on opts.transport.

See example of the failing test: googleapis/python-resource-settings#118.

@atulep atulep requested review from a team as code owners June 28, 2022 17:45
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 28, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 28, 2022
@atulep atulep added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2022
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one observation.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2022
@parthea parthea changed the title fix: fixes bug with generated test. fix: resolve issue where rest test appears in grpc-only client Jul 4, 2022
@parthea parthea merged commit 22cd2ca into googleapis:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants