fix: set default argument of jinja-filters.map() when looking up attributes
#1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
vchudnov-g
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Thanks for doing this.
It might be good to add to the PR description why we're doing this. Though I haven't found a statement to this effect in the official Jinja documentation, this issue suggests that if the key isn't set and we don't set a default, then map returns a LookupError.
ohmayr
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When jinja-filters.map is used to look up an attribute, the
defaultargument should be set in case an object in the list does not have the given attribute.