Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow warehouse name to be customized #717

Merged
merged 3 commits into from
Dec 22, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 22, 2020

Allow warehouse name (package name in setup.py) to be customized via a CLI option.

This is a pretty common reason for a synth.py regex replace:

  • One repo has more than one API (e.g., Bigtable and Bigtable Admin) but the package name should always be google-cloud-bigtable
  • We want an extra - in the repo name and package name to make it easier to read and type. (google-cloud-binaryauthorization -> google-cloud-binary-authorization)
  • Package name constructed from the namespace doesn't match the google-cloud-{API} convention (google-cloud-devtools-containeranalysis -> google-cloud-containeranalysis)

Fixes #605

@busunkim96 busunkim96 requested a review from a team as a code owner December 22, 2020 01:18
@busunkim96 busunkim96 changed the title feat: allow package name to be customized feat: allow warehouse name to be customized Dec 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #717 (f73bae1) into master (39be474) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #717   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1602      1608    +6     
  Branches       326       328    +2     
=========================================
+ Hits          1602      1608    +6     
Impacted Files Coverage Δ
gapic/schema/naming.py 100.00% <100.00%> (ø)
gapic/utils/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39be474...f73bae1. Read the comment docs.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7c185e8 into master Dec 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 22, 2020
@busunkim96 busunkim96 deleted the allow-custom-package-name branch January 21, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow package name to be customized via a generator option
2 participants