Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Grpc::Core::StatusCodes constants #206

Closed
blowmage opened this issue Aug 12, 2019 · 3 comments
Closed

Use Grpc::Core::StatusCodes constants #206

blowmage opened this issue Aug 12, 2019 · 3 comments
Assignees
@blowmage
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blowmage
Copy link
Contributor

Whenever a status code is referenced, such as in the RPC retry configuration, use the Grpc::Core::StatusCodes constants instead of the numeric value of each code.
@blowmage
Copy link
Contributor Author

This is difficult as Grpc::Core::StatusCodes is defined in the C library at runtime. So we can't reference these constants until the Grpc C library has been loaded. However, the PR grpc/grpc#19893 has been opened to allow for this usage.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 13, 2019
@jbolinger jbolinger added this to To do in Cloud Aug 14, 2019
@jbolinger jbolinger removed this from To do in Cloud Aug 14, 2019
@blowmage
Copy link
Contributor Author

We have grpc changes to allow for this (grpc/grpc#19893), and it looks like it won't be released until grpc version 1.24.0.

@blowmage blowmage added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Aug 14, 2019
@blowmage blowmage self-assigned this Aug 14, 2019
@blowmage
Copy link
Contributor Author

blowmage commented Jan 6, 2020

Added in #246.

@blowmage blowmage closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blowmage blowmage

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blowmage @yoshi-automation