feat: parse details information from REST errors #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
requested changes
Sep 12, 2022
gapic-generator-cloud/templates/cloud/service/rest/client/method/def/_rescue.erb
Show resolved
Hide resolved
|
Fixed the comments, please TAL |
dazuma
requested changes
Sep 13, 2022
gapic-common/lib/gapic/rest/error.rb
Outdated
| code = body["error"]["code"] | ||
| unless body.is_a?(::Hash) && body&.key?("error") && body["error"].is_a?(::Hash) | ||
| return [nil, nil, nil, | ||
| nil] |
There was a problem hiding this comment.
Sorry, I guess I wasn't clear enough on the nit. The array doesn't need to be split across two lines. 🙂
|
Fixed, please TAL |
dazuma
approved these changes
Sep 14, 2022
gapic-common/lib/gapic/rest/error.rb
Outdated
| code = body["error"]["code"] | ||
| unless body.is_a?(::Hash) && body&.key?("error") && body["error"].is_a?(::Hash) | ||
| return [nil, nil, nil, | ||
| nil] |
There was a problem hiding this comment.
Sorry, I guess I wasn't clear enough on the nit. The array doesn't need to be split across two lines. 🙂
viacheslav-rostovtsev
force-pushed
the
feat/parse_details_faraday_error
branch
from
e464880
to
2b59dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.