-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse details information from REST errors #815
feat: parse details information from REST errors #815
Conversation
gapic-generator-cloud/templates/cloud/service/rest/client/method/def/_rescue.erb
Show resolved
Hide resolved
Fixed the comments, please TAL |
gapic-common/lib/gapic/rest/error.rb
Outdated
code = body["error"]["code"] | ||
unless body.is_a?(::Hash) && body&.key?("error") && body["error"].is_a?(::Hash) | ||
return [nil, nil, nil, | ||
nil] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I guess I wasn't clear enough on the nit. The array doesn't need to be split across two lines. 🙂
Fixed, please TAL |
gapic-common/lib/gapic/rest/error.rb
Outdated
code = body["error"]["code"] | ||
unless body.is_a?(::Hash) && body&.key?("error") && body["error"].is_a?(::Hash) | ||
return [nil, nil, nil, | ||
nil] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I guess I wasn't clear enough on the nit. The array doesn't need to be split across two lines. 🙂
e464880
to
2b59dd0
Compare
No description provided.