Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce google.api.api_version option to generated clients #1074

Merged
merged 6 commits into from May 3, 2024

Conversation

aandreassa
Copy link
Contributor

@aandreassa aandreassa commented May 2, 2024

Note: some updates in showcase tests take into account googleapis/gapic-showcase#1501, where other request headers are now part of trailing_metadata.

@aandreassa aandreassa marked this pull request as ready for review May 2, 2024 01:15
@aandreassa aandreassa requested a review from a team as a code owner May 2, 2024 01:15
@aandreassa aandreassa requested a review from dazuma May 2, 2024 01:16
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor Ruby nit.

gapic-generator/lib/gapic/presenters/service_presenter.rb Outdated Show resolved Hide resolved
@aandreassa aandreassa merged commit df0504f into main May 3, 2024
12 checks passed
@aandreassa aandreassa deleted the generate-api-version branch May 3, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants