Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (diregapic)missing error from ads #878

Merged
merged 1 commit into from May 24, 2021
Merged

fix: (diregapic)missing error from ads #878

merged 1 commit into from May 24, 2021

Conversation

summer-ji-eng
Copy link
Collaborator

@summer-ji-eng summer-ji-eng commented May 20, 2021 •
edited

fix #874 : googleads protos are different than most other apis.
It has multiple packages, like

package google.ads.googleads.v7.services;
package google.ads.googleads.v7.errors;

And errors.proto has no service.

Fix: we should allow package'name which has no service differ from service package name.

Local Test: generate googleads

$ bazel build //google/ads/googleads/v7:googleads-nodejs
$ cd .../bazel-bin/google/ads/googleads/v7
$ tar -xf googleads-nodejs.tar.gz
$ grep errors.proto googleads-nodejs/src/v7/*json | wc -l

Results: 126

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 20, 2021 18:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
This was referenced May 20, 2021
Closed
Closed
@alexander-fenster alexander-fenster merged commit 1613b8e into master May 24, 2021
@alexander-fenster alexander-fenster deleted the fix_missing_ads branch May 24, 2021 23:56
copybara-service bot pushed a commit to googleapis/googleapis that referenced this pull request May 25, 2021
fix: GoogleAdsError missing using generator version after 1.3.0
95fa72f 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421
gcf-owl-bot bot added a commit to googleapis/nodejs-workflows that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
99b517d 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-web-security-scanner that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
6bfc7e3 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-web-risk that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
ff07b64 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-vision that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
30220b4 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-video-transcoder that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
7a06c72 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-video-intelligence that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
6506fd1 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-translate that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
dd3dca3 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-text-to-speech that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
205ceae 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-tasks that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
1cfa828 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
gcf-owl-bot bot added a commit to googleapis/nodejs-talent that referenced this pull request May 25, 2021
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0
eb5d588 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
@gcf-owl-bot gcf-owl-bot bot mentioned this pull request May 25, 2021
Merged
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#56)
302d94e 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#53)
9d7ba0a 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#51)
99b12e7 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#52)
dc3903f 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#42)
7883a2a 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#52)
a2115ca 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#171)
2f78e96 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#118)
a0a5a12 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#456)
950fb48 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#122)
b728756 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#48)
619cc81 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#33)
6d59cad 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#54)
ec1200a 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#49)
85917bc 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#9)
48ae0bd 
* fix: GoogleAdsError missing using generator version after 1.3.0

[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#3)
74057d7 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#30)
c71ecfc 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#52)
c99cbfa 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#47)
1c4e2bd 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#279)
23360a5 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#89)
fc01df1 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 16, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#55)
ddfe74d 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Nov 18, 2022
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#385)
2af0139 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 10, 2023
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#615)
3444af2 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 17, 2023
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#908)
6dd990f 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 24, 2023
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#755)
f753f94 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 25, 2023
@gcf-owl-bot
fix: GoogleAdsError missing using generator version after 1.3.0 (#755)
9a5240b 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Jan 26, 2023
@gcf-owl-bot @JustinBeckwith
fix: GoogleAdsError missing using generator version after 1.3.0 (#141)
5d71393 
* fix: GoogleAdsError missing using generator version after 1.3.0

[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
FPiety0521 pushed a commit to FPiety0521/text-to-speech-nodejs- that referenced this pull request Apr 23, 2023
@Prometheus2677 @gcf-owl-bot @JustinBeckwith
fix: GoogleAdsError missing using generator version after 1.3.0 (#515)
13144ed 
* fix: GoogleAdsError missing using generator version after 1.3.0

[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f40a34377ad488a7c2bc3992b3c8d5faf5a15c46

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Sep 13, 2023
@gcf-owl-bot
fix: REST fallback client header (#513)
ca6fdf4 
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Link: googleapis/googleapis@95fa72f

Source-Link: googleapis/googleapis-gen@f40a343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix errors missing from ads nodejs GAPIC lib
2 participants
@summer-ji-eng @alexander-fenster