Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Update test resources to use new Resource definitions #2415

Merged
merged 5 commits into from Nov 9, 2018

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Nov 8, 2018

  • use the new resource_definition annotation
  • make Resource.name and ResourceSet.name be CamelCase
  • expand all paths to include resource identifiers as wildcards, e.g. projects/{project} instead of projects/*
  • use resource_references in the ResourceSet
  • temporarily remove references to google.api.Project, which has been deleted in https://github.com/googleapis/api-common-protos/pull/20/files

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #2415 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2415      +/-   ##
============================================
- Coverage     86.72%   86.72%   -0.01%     
+ Complexity     5243     5242       -1     
============================================
  Files           458      458              
  Lines         20881    20870      -11     
  Branches       2252     2252              
============================================
- Hits          18110    18099      -11     
  Misses         1968     1968              
  Partials        803      803
Impacted Files Coverage Δ Complexity Δ
...api/codegen/transformer/java/JavaSurfaceNamer.java 91.8% <0%> (-0.45%) 53% <0%> (-1%)
...en/transformer/php/PhpGapicSurfaceTransformer.java 92.95% <0%> (-0.08%) 41% <0%> (ø)
.../transformer/py/PythonGapicSurfaceTransformer.java 98.29% <0%> (-0.01%) 43% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8e2b3...b704316. Read the comment docs.

@andreamlin
Copy link
Contributor Author

PTAL

@@ -2,7 +2,7 @@ type: com.google.api.codegen.ConfigProto
config_schema_version: 1.0.0
language_settings:
java:
package_name: com.google.gcloud.pubsub.v1
package_name: com.google.example.library.v1

This comment was marked as spam.

@andreamlin andreamlin merged commit 8f8a352 into googleapis:master Nov 9, 2018
@andreamlin andreamlin deleted the update_test_resources branch November 9, 2018 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants