New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace api-common-protos submodule with googleapis #1395
Conversation
You'll want to change these spots to make CI/regen happy: gapic-showcase/util/compile_protos.go Line 58 in 1d6dde2
gapic-showcase/util/cmd/release/main.go Line 68 in 1d6dde2
gapic-showcase/util/cmd/release/main.go Line 78 in 1d6dde2
gapic-showcase/util/cmd/release/main.go Line 83 in 1d6dde2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is definitely better. Just one question
Awesome stuff, thank you @alicejli, reducing toil!! |
https://github.com/googleapis/api-common-protos needs to be manually updated, so there is a 2-step process for
gapic-showcase
to pull in updatedapi-common-protos
. By replacing theapi-common-protos
submodule withgoogleapis
, it removes one of those steps.