Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace api-common-protos submodule with googleapis #1395

Merged
merged 7 commits into from Dec 20, 2023

Conversation

alicejli
Copy link
Contributor

https://github.com/googleapis/api-common-protos needs to be manually updated, so there is a 2-step process for gapic-showcase to pull in updated api-common-protos. By replacing the api-common-protos submodule with googleapis, it removes one of those steps.

@noahdietz
Copy link
Collaborator

You'll want to change these spots to make CI/regen happy:

"--proto_path=schema/api-common-protos",

apiPath := filepath.Join("schema", "api-common-protos", "google", "api")

longrunningPath := filepath.Join("schema", "api-common-protos", "google", "longrunning")

rpcPath := filepath.Join("schema", "api-common-protos", "google", "rpc")

@alicejli alicejli closed this Dec 20, 2023
@alicejli alicejli reopened this Dec 20, 2023
@alicejli alicejli marked this pull request as ready for review December 20, 2023 15:54
@alicejli alicejli requested review from a team as code owners December 20, 2023 15:54
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is definitely better. Just one question

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@noahdietz
Copy link
Collaborator

Awesome stuff, thank you @alicejli, reducing toil!!

@noahdietz noahdietz merged commit d72c489 into main Dec 20, 2023
11 checks passed
@noahdietz noahdietz deleted the replaceSubModule branch December 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants